Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding codeowners file creation script #32

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

SonOfLope
Copy link
Contributor

This pull request gives the following :

  • update ruleset for branch protection to require review from code owners
  • sh script that creates a CODEOWNERS file in repo's which names end with "backend", "frontend" or "db". Also adds devops teams as code owners for all .github folder and Dockerfiles/docker-compose files across all repositories.

Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the repository devops itself is lacking the Github Workflows to lint markdown and would need linter setup for shell scripts.

@SonOfLope
Copy link
Contributor Author

Shellcheck will be used with the action shell-linter.
I applied Shellcheck for the current pull request to make sure it passes the check. The following issue will add the reusable action workflow.

@SonOfLope
Copy link
Contributor Author

Added sh check workflow. The pipeline wont work for now since we need to wait until the workflow gets merged on github-workflow.

As for the newline, the workflow seems to run but doesnt detect that the file doesnt have new line :
image
I will investigate.

@SonOfLope SonOfLope requested a review from rngadam March 1, 2024 21:04
@rngadam
Copy link

rngadam commented Mar 4, 2024

I will investigate.

Suggest referencing the issue into which the investigation / fix is being done. Also good place to use "Reference in new issue".

Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment on linking to related issues.

@SonOfLope SonOfLope merged commit 9e00dd6 into main Mar 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants