Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #85: Write an ADR-010 about the infrastructure #86

Merged
merged 50 commits into from
May 1, 2024

Conversation

ThomasCardin
Copy link
Member

@ThomasCardin ThomasCardin commented Dec 15, 2023

@ThomasCardin ThomasCardin self-assigned this Dec 15, 2023
@ThomasCardin ThomasCardin linked an issue Dec 15, 2023 that may be closed by this pull request
9 tasks
@ThomasCardin ThomasCardin marked this pull request as draft December 15, 2023 19:05
@ThomasCardin ThomasCardin changed the title Fixes #85: Write an ADR about the infrastruture Fixes #85: Write an ADR about the infrastructure Dec 15, 2023
@ThomasCardin ThomasCardin changed the title Fixes #85: Write an ADR about the infrastructure Fixes #85: Write an ADR-010 about the infrastructure Jan 3, 2024
Copy link
Contributor

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Not sure why the checks pass here, we're supposed to be checking for markdown line length to be wrapping at 80
  • choose one language and write the file for that and then translate as a final step, don't have both files in (especially since they are out of sync - and then I don't know why one we should be reviewing.

adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
adr/010-infrastructure.fr-ca.md Outdated Show resolved Hide resolved
@rngadam
Copy link
Contributor

rngadam commented Feb 15, 2024

@ThomasCardin @SonOfLope are we following up on this?

@SonOfLope
Copy link
Contributor

SonOfLope commented Feb 15, 2024

@ThomasCardin @SonOfLope are we following up on this?

@ThomasCardin correct me if I'm wrong but we agreed we were gonna take our time on writing this since some of the structure hasn't been fully implemented yet. We're following up on it as we work on Howard.

Copy link
Contributor

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, we're keeping track of the different solutions we tried and have documentation.

can we add links to the canonical website for each solution?

adr/011-gitops.fr-ca.md Show resolved Hide resolved
adr/010-infrastruture.en-ca.md Outdated Show resolved Hide resolved
@SonOfLope SonOfLope self-assigned this Apr 10, 2024
Copy link

@MaxenceGui MaxenceGui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few language mistake to correct

adr/013-IaC-tool.fr-ca.md Outdated Show resolved Hide resolved
adr/013-IaC-tool.fr-ca.md Outdated Show resolved Hide resolved
adr/014-containers.fr-ca.md Outdated Show resolved Hide resolved
adr/015-authentication-management.fr-ca.md Outdated Show resolved Hide resolved
adr/016-networking.fr-ca.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ibrahim-kabir ibrahim-kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work.

.vscode/settings.json Outdated Show resolved Hide resolved
SonOfLope and others added 6 commits April 22, 2024 09:14
Copy link

@amirardalan9473 amirardalan9473 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could only read the english files.

@ThomasCardin ThomasCardin merged commit a11d676 into main May 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants