137 create a function for container name creation logic #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't write
I will write unittest to make sure the 2 functions behave as expected soon (current tests workflow are broken atm). Previous tests should tell us if the changes are working for the refactoring. |
k-allagbe
approved these changes
Oct 10, 2024
|
I will rebase on main and check if any tests are having issues atm. I will then add new tests where it is necessary and update the old tests with the new functions! |
Francois-Werbrouck
force-pushed
the
137-create-a-function-for-container-name-creation-logic
branch
from
7a507e3
to
0f8bddb
Compare
|
There seems to be issues with certain tests. I will look into it first thing next week! 🚀 |
| @@ -50,6 +50,37 @@ async def generate_hash(image): | |||
| print(error.__str__()) | |||
| raise Exception("Unhandeled Datastore.blob.azure_storage Error") | |||
|
|
|||
| def build_container_name(name:str,tier:str="user"): | |||
There was a problem hiding this comment.
The spacing on the types does not look right. Are we running ruff on these files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #137