Skip to content
This repository has been archived by the owner on Jun 15, 2024. It is now read-only.

deploymentBucket should defaults to reading from core #116

Open
vicary opened this issue Aug 4, 2022 · 2 comments
Open

deploymentBucket should defaults to reading from core #116

vicary opened this issue Aug 4, 2022 · 2 comments

Comments

@vicary
Copy link

vicary commented Aug 4, 2022

Serverless is able to generate its own deployment bucket and this plugin should be able to read from it when not explicitly specified by users.

@agutoli
Copy link
Owner

agutoli commented Dec 26, 2022

It's a bit more complicated than it seems. That library runs before the hook that creates the default bucket, and I tried that before and I got a few issues that I can't remember now, but I reckon we need to attach the layer before before:package:initialize because serverless also check for changes (like when layer arn is attached/updated), for instance. So, when this plugin identifies a new change, it attaches the new arn to each function, and then sls is responsible to the handler after that. Not saying its impossible, but it probably will require a re-think on this library which probably makes more sense to do on next implementation maybe on serverless-layers 3.0

@vicary
Copy link
Author

vicary commented Dec 26, 2022

@agutoli please take your time. We will fallback to a static bucket for existing projects, our future projects would definitely benefit when 3.0 is out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants