Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENVIRONMENT required. Needs fallback #2

Open
petehalverson opened this issue Dec 16, 2017 · 2 comments
Open

ENVIRONMENT required. Needs fallback #2

petehalverson opened this issue Dec 16, 2017 · 2 comments

Comments

@petehalverson
Copy link

The ENVIRONMENT constant you're referencing (
https://github.com/agungjk/phpdotenv-for-codeigniter/blob/master/system/dotenv/Dotenv.php#L29) may not be defined. I think Dotenv should fall back to a standard .env if that's the case.
@petehalverson petehalverson changed the title ENVIRONMENT required. ENVIRONMENT required. Needs fallback Dec 16, 2017
petehalverson added a commit to petehalverson/phpdotenv-for-codeigniter that referenced this issue Dec 16, 2017
@petehalverson
Check if ENVIRONMENT is defined
4b378b5 
Fixes agungjk#2
petehalverson added a commit to petehalverson/phpdotenv-for-codeigniter that referenced this issue Dec 16, 2017
@petehalverson
Check if ENVIRONMENT is defined
075c34c 
Fixes agungjk#2
@petehalverson
Copy link
Author

I should mention I'm using this with a pretty old version of CodeIgniter (v1.7.3), maybe the ENVIRONMENT constant is defined as part of newer convention.

@petehalverson petehalverson reopened this Dec 17, 2017
@agungjk
Copy link
Owner

agungjk commented Feb 8, 2018 •
edited
Loading

@petehalverson sory for that, i didn't test on that version before
just create a pull, i will merge this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petehalverson @agungjk