"Silently drop tables with no PKs rather than failing (bad idea??)"

[JordanReiter]

I'd like to put in a vote that says this is a terrible idea. I think a good use case for this library will be making data from an older, legacy database available. Bookrest should definitely not alter the schema of databases in any way.

Specifically excluding rather than altering databases without PKs is a much better idea.

In fact, I think you should add configuration variables that let you either exclude or specifically whitelist tables to expose to the API.

Logic would be:

tables = self.get_tables()
if hasattr(settings, 'BOOKREST_TABLES'):
    tables = [table for table in tables if table in settings.BOOKREST_TABLES]
elif hasattr(settings, 'BOOKREST_EXCLUDE'):
    tables = [table for table in tables if table not in settings.BOOKREST_EXCLUDE]
tables = [table for table in tables if has_primary_key(table)] # exercise for reader
return [self.get_model(table.name) for table in tables]

[ztroop]

I agree with @JordanReiter completely! The module should not alter the schema in any way.
It would be more ideal to include or exclude certain tables from the API.

[shabda]

haha, I think I need to get better at expressing my ideas. I am not thinking about dropping the table! That would be crazy. :)

I am thinking disregarding them like @JordanReiter write the code for (aka dropping from Bookrest UI). If you open a PR, I will merge it.

[shabda]

I have updated the readme to Silently drop disregard tables with no PKs