Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve log report #404

Merged
merged 2 commits into from
Sep 16, 2023
Merged

improve log report #404

merged 2 commits into from
Sep 16, 2023

Conversation

agateau
Copy link
Owner

@agateau agateau commented Sep 16, 2023

  • Log preferences before exporting logs
  • AndroidLogExporter: fix odd warnings in logcat

@agateau
Log preferences before exporting logs
3728351
@agateau
AndroidLogExporter: fix odd warnings in logcat
22be75a 
The existing code works fine right now, but it spams the logcat with
permission warnings. Switch to using ShareCompat, which does the same job
without warnings. This should avoid this code silently breaking behind my
back in the future.
@agateau agateau added the skip-changelog Used on PR to indicate changes which do not require a changelog entry label Sep 16, 2023
@agateau agateau merged commit a4e7d49 into master Sep 16, 2023
5 checks passed
@agateau agateau deleted the improve-log-report branch September 16, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip-changelog Used on PR to indicate changes which do not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@agateau