Added unit tests covering previously inconsistent component update behaviour #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Following #5474 this PR adds a couple of unit tests covering the bugs that have been fixed. These are adopted from the (glitch) reproductions in the respective issues. All of them fail prior to #5474.
Changes proposed:
NaNfor numeric, single-property component schemas in 0.7.* and 0.8.0 #3442, Updating a line component using a cached THREE.Vector3 fails #3681, Single-prop value not parsed when using utils.entity.setComponentProperty #4018