Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json shelljs dependabot Severity High 7.1 / 10 #5497

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arpu
Copy link
Contributor

@arpu arpu commented Mar 20, 2024

@dmarcos
Copy link
Member

dmarcos commented Mar 20, 2024

Yeah it's used to deploy the examples. This is also a dev dependency. not bundled in the library

@arpu
Copy link
Contributor Author

arpu commented Mar 20, 2024

dependabot do not like it :) i could not test it, but would be nice to include the update

@dmarcos
Copy link
Member

dmarcos commented Mar 20, 2024

We gotta make sure there are no regressions. Also is a dev dependency that it's only used for A-Frame deployment. Pretty safe to ignore those warnings.

@arpu
Copy link
Contributor Author

arpu commented Mar 20, 2024

i understand, but for some securty audits ( iso ) this is not allowed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants