Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack to latest supported version #5480

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

vincentfretin
Copy link
Contributor

Description:

Update build tools dependencies.

Changes proposed:

  • Update webpack and associated loaders
  • Update webpack-dev-server, this requires now at least node 18.12.0 that everyone should have, older versions of node aren't supported anymore. Current LTS is node 20.x
  • Remove webpack-merge dependency, webpack now supports extending another configuration with "extends"

@dmarcos
Copy link
Member

dmarcos commented Feb 29, 2024

Are any of these updates needed? In general I avoid updating dependencies unless there's a reason to do so. If things work no reason to get exposed to API changes, regressions, new bugs

@vincentfretin
Copy link
Contributor Author

Not currently needed per se, just maintenance, so we don't need to check the changelog of 30 versions of those dependencies in 5 years when we really need to upgrade because of a blocker like we had with budo and self-signed certificate not working on ubuntu 22.04.

Please be aware that we don't push package-lock.json in the repo, so we effectively auto upgrade all those dependencies when you freshly git clone the repo and run npm install.
Here are the only real upgrades:

  • "webpack-cli" from "4.x.x" to 5.x.x"
  • "webpack-dev-server" from "4.x.x" to "5.x.x"
  • "babel-loader" from "8.x.x" to "9.x.x"

that removes support for node 16.x. That's the only api changes as far as I'm aware after reading the changelogs. The dist didn't change after those upgrades.
And this also remove webpack-merge dependency, that's always nice to remove dependencies.

Feel free to leave it open until we really need it. I'll just update it the next time I read the changelogs in a year :D

@vincentfretin
Copy link
Contributor Author

@dmarcos now that the bot is using node 22.7.0 I don't see any reason to not merge this.

@dmarcos
Copy link
Member

dmarcos commented Sep 17, 2024

@vincentfretin is this a one time thing or we will have to continuously update webpack and stuff. Would prefer to avoid get on the train of updating packages just for the shake of it. Can of course update if there's a reason to do so

@vincentfretin
Copy link
Contributor Author

That's a one time thing to remove a dependency, otherwise I wouldn't have bothered to do this PR.

…m version required, remove webpack-merge, webpack now supports extending another configuration
@dmarcos
Copy link
Member

dmarcos commented Sep 18, 2024

Thanks!

@dmarcos dmarcos merged commit b17f760 into aframevr:master Sep 18, 2024
3 checks passed
@vincentfretin vincentfretin deleted the update-webpack branch September 18, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants