Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Console font is not Roboto Mono anymore #191

Open
ylacaute opened this issue Sep 22, 2021 · 2 comments
Open

BUG - Console font is not Roboto Mono anymore #191

ylacaute opened this issue Sep 22, 2021 · 2 comments

Comments

@ylacaute
Copy link

ylacaute commented Sep 22, 2021

The material theme do not use Roboto Mono anymore for the console (as the result it breaks my beautiful ascii arts haha)

The problem comes from here :

:not(div.ace_editor) {
    font-family: Roboto,sans-serif !important;
    outline: 0;
}

If we remove !important, it is working
If we replace Roboto by Roboto Mono, it is working

I did'nt tested in a real Jenkins, but I think Roboto should be Roboto Mono, => PR 190

@senthil13
Copy link

senthil13 commented Nov 3, 2021

+1, I am also facing the issue.
but I would prefer removing the !important method. changing Roboto to Roboto Mono caused all fonts to change, but the first one only change the console output.

Thanks
Senthil.

@ylacaute
Copy link
Author

Indeed ! In fact we need to remove !important at 2 places :

#main-panel > pre {
    font-family: Roboto Mono,monospace !important;
}

:not(div.ace_editor) {
    font-family: Roboto,sans-serif !important;
    outline: 0;
}

We can guess this !important has been added for reason, it is then complicated to do a PR.

You can see the result with this : https://github.com/ylacaute/jenkins-material-theme-blue-grey-fixed (personally I don't really see any difference, excepted the console is now monospace which is very important)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants