You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In ftp://ftp.freetds.org/pub/freetds/stable/ there are lots of ftp://ftp.freetds.org/pub/freetds/stable/freetds-1.00.1.tar.gz where the version is 1.00... and your semver checking doesn't like it.
...
File "/opt/resource/check", line 217, in _versions_to_output
versions.sort(key=lambda x: semver.parse_version_info(x[self.version_key]))
File "/opt/resource/check", line 217, in <lambda>
versions.sort(key=lambda x: semver.parse_version_info(x[self.version_key]))
File "/usr/local/lib/python3.6/site-packages/semver.py", line 131, in parse_version_info
parts = parse(version)
File "/usr/local/lib/python3.6/site-packages/semver.py", line 52, in parse
raise ValueError('%s is not valid SemVer string' % version)
ValueError: 1.00.1 is not valid SemVer string
Could we allow the test to be more flexible?
The text was updated successfully, but these errors were encountered:
drnic
added a commit
to Qarik-Group/freetds-buildpack
that referenced
this issue
Jun 8, 2019
I'm not really keen on solving this problem myself right now. But if you want to give it a try I would gladly accept a generic solution. Like adding a parameter to specify different well defined/custom versioning schemes, with semver being the default for backwards compatibility.
I don't know why they put
00
in their versions :/In ftp://ftp.freetds.org/pub/freetds/stable/ there are lots of ftp://ftp.freetds.org/pub/freetds/stable/freetds-1.00.1.tar.gz where the version is
1.00...
and your semver checking doesn't like it.Could we allow the test to be more flexible?
The text was updated successfully, but these errors were encountered: