Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/auth-error #364

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix/auth-error #364

wants to merge 3 commits into from

Conversation

maximeroucher
Copy link
Member

Goal of this PR : Close #354

Description of the added features :

  • Improving error message
  • Logging them
  • Displaying them on toast

@maximeroucher maximeroucher added enhancement New feature or request core This PR change the core fix bug This PR fix a bug labels May 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 54.01%. Comparing base (4ea36c2) to head (0d018f9).

Files Patch % Lines
lib/auth/providers/openid_provider.dart 0.00% 58 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #364   +/-   ##
=======================================
  Coverage   54.01%   54.01%           
=======================================
  Files         168      168           
  Lines        3710     3710           
=======================================
  Hits         2004     2004           
  Misses       1706     1706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@armanddidierjean armanddidierjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need investigation, the PR may break both login and logout

@julien4215 julien4215 marked this pull request as draft June 13, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core This PR change the core enhancement New feature or request fix bug This PR fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors during get auth/token are not explained
3 participants