Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dark theme #408

Open
Marc-Andrieu opened this issue Jul 7, 2024 · 0 comments
Open

Enable dark theme #408

Marc-Andrieu opened this issue Jul 7, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Marc-Andrieu
Copy link
Contributor

Create a dark mode version for the client.

1. Have a dark theme that works: currently, most colors are hardcoded

  • So the UI will hardly see any changes if we say "the theme is dark"; it lacks the flexibility of some "color factorization".
  • Therefore we'll have to agree on some sets of colors.

2. Decide what chooses the theme:

  • What is the default? Light theme or system theme?
  • Allow users to toggle the theme by means of a switch in the UI
  • Remember the user's preference. If no, it might bother the user... If yes:
    • Remember w.r.t. the user?
      • I don't see any advantage to it: involving Hyperion (and to store a UI-related thing); the correct theme would only be applied after logging in + the usual loading time; and what if a user wants the dark theme on phone but the light theme on computer?
    • Remember device-wise?
      • Definitively easier to implement (Hyperion not involved), better UX (the login page could be dark!), more flexible for multiple devices.
@Marc-Andrieu Marc-Andrieu added enhancement New feature or request help wanted Extra attention is needed labels Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant