Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Request Internal LAN Detection Doesn't Support user:pass@uri #70

Open
adorsett opened this issue Feb 22, 2017 · 0 comments
Open

Web Request Internal LAN Detection Doesn't Support user:pass@uri #70

adorsett opened this issue Feb 22, 2017 · 0 comments

Comments

@adorsett
Copy link

The code which detects Internal LAN addresses needs some additional logic to detect if there is a username:password@ combination between the protocol and uri. Right now it simply checks if the URI starts with 10., 192.168., or 172.16.

ex: http://username:[email protected]/rest/set/vars/2/1/1

While at it, if a username is detected and it's an email address, the '@' should be replaced by '%40' to make it more user friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant