Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click event on underlay closes the select + dialog and triggers a link behind it #7116

Open
maximpostnikov opened this issue Sep 27, 2024 · 5 comments

Comments

@maximpostnikov
Copy link

maximpostnikov commented Sep 27, 2024

Provide a general summary of the issue here

When clicking on an underlay (a div with position: fixed), it closes the select as expected, but it also triggers any link that is positioned behind the underlay.

🤔 Expected Behavior?

Clicking anywhere on the underlay should only close the select and not trigger any links or other elements behind it.

😯 Current Behavior

Currently, when clicking on the underlay in an area where there is a link behind it, the select closes as expected, but the link behind the underlay also gets triggered. The link should not be clickable in this case.

💁 Possible Solution

No response

🔦 Context

No response

🖥️ Steps to Reproduce

Screen.Recording.2024-09-27.at.20.23.53.mov

Version

1.3.3

What browsers are you seeing the problem on?

Chrome (129.0.6668.70, Responsive Viewport Mode, Type: Mobile (with touch)), Microsoft Edge (129.0.2792.65, Responsive Viewport Mode, Type: Mobile (with touch)), Firefox (130.0.1, Responsive Design Mode, Touch simulation), Safari (iOS 18)

If other, please specify.

No response

What operating system are you using?

macOS Sequoia

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@reidbarber
Copy link
Member

reidbarber commented Sep 27, 2024

I'm only seeing this in Chrome's Simulated Device mode. Are you observing this in all the browsers mentioned? Also note that #7026 will be included in the next release, not sure if that is related.

@maximpostnikov
Copy link
Author

maximpostnikov commented Sep 27, 2024

@reidbarber I built the project locally considering #7026, but the bug is still present. As far as I can tell, this PR is not related to useOverlay.

I think the issue occurs in all browsers, for example, in Safari on iOS 18:

ScreenRecording_09-28-2024.00-00-15_1.MP4

@reidbarber
Copy link
Member

Interesting, I'm not observing this in Chrome, Safari, or Firefox on Mac OS 14.6.1.

Screen.Recording.2024-09-27.at.5.48.10.PM.mov

@maximpostnikov
Copy link
Author

@reidbarber this problem is not reproduced if you go to chrome responsive mode and select mobile type to emulate touch actions?

@reidbarber
Copy link
Member

This issue listed Firefox, Chrome, Safari, and Microsoft Edge under 'What browsers are you seeing this on?', so I was confirming if it was present in those since I didn't see it in those without turning on simulated device mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants