Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky data-hovered on Row if Popover can be opened from inside it #7004

Open
levrik opened this issue Sep 6, 2024 · 5 comments
Open

Sticky data-hovered on Row if Popover can be opened from inside it #7004

levrik opened this issue Sep 6, 2024 · 5 comments

Comments

@levrik
Copy link

levrik commented Sep 6, 2024

Provide a general summary of the issue here

When a Popover can be opened from inside a Row with href, data-hovered can get stuck after closing the Popover again.

🤔 Expected Behavior?

data-hovered gets removed after the Popover has been closed. I think it's kinda expected to stay while the Popover is open even if the cursor has been moved away from the Row.

😯 Current Behavior

When a Popover is opened from inside a Row with href, data-hovered is stuck after closing the Popover again if the cursor has been moved above another row.

💁 Possible Solution

I understand that this might be tricky to solve as the Row is missing mouse events while the popover is open. Maybe a check on the mouse position could be done after the Popover has been closed?

🔦 Context

No response

🖥️ Steps to Reproduce

React.Aria.Table.Row.Hover.+.Popover.mp4

https://codesandbox.io/s/purple-pond-qssgxg

Version

1.3.3

What browsers are you seeing the problem on?

Chrome, Microsoft Edge

If other, please specify.

No response

What operating system are you using?

macOS

🧢 Your Company/Team

No response

🕷 Tracking Issue

No response

@snowystinger
Copy link
Member

Thanks for the issue! Probably an issues with React and the way they bubble events through portals. Probably best to start by seeing if we are already ignoring hover events if they come through a portal.

@levrik
Copy link
Author

levrik commented Sep 9, 2024

@snowystinger I don't think this has anything to do with React but simply that the mouseout/mouseleave event never fires on the Row as the Popover puts a full screen overlay over everything except the Popover itself. When the Popover then closes the mouse cursor is in a different position and the Row never noticed that it's not being hovered anymore.

@snowystinger
Copy link
Member

Also very possible. We'll want to make sure that is the root of the issue in order to start thinking about a fix.

@levrik
Copy link
Author

levrik commented Sep 9, 2024

@snowystinger Just to ensure I'm not misunderstanding you: Do you expect me to verify this or is it something the React Aria team wants to do?

Just to be clear: I'm open to also investigate a bit more from my side in case I find time for it. Just want to ensure that expections are set correctly 😅

@snowystinger
Copy link
Member

Anyone, just trying to make it easier for anyone to look at by providing some pointers based on past issues.

If you want it prioritized, then it's in your best interest to have a go at it. Otherwise it'll have to fit into our priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants