-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sticky data-hovered
on Row
if Popover
can be opened from inside it
#7004
Comments
Thanks for the issue! Probably an issues with React and the way they bubble events through portals. Probably best to start by seeing if we are already ignoring hover events if they come through a portal. |
@snowystinger I don't think this has anything to do with React but simply that the |
Also very possible. We'll want to make sure that is the root of the issue in order to start thinking about a fix. |
@snowystinger Just to ensure I'm not misunderstanding you: Do you expect me to verify this or is it something the React Aria team wants to do? Just to be clear: I'm open to also investigate a bit more from my side in case I find time for it. Just want to ensure that expections are set correctly 😅 |
Anyone, just trying to make it easier for anyone to look at by providing some pointers based on past issues. If you want it prioritized, then it's in your best interest to have a go at it. Otherwise it'll have to fit into our priorities. |
Provide a general summary of the issue here
When a
Popover
can be opened from inside aRow
withhref
,data-hovered
can get stuck after closing thePopover
again.🤔 Expected Behavior?
data-hovered
gets removed after thePopover
has been closed. I think it's kinda expected to stay while thePopover
is open even if the cursor has been moved away from theRow
.😯 Current Behavior
When a
Popover
is opened from inside aRow
withhref
,data-hovered
is stuck after closing thePopover
again if the cursor has been moved above another row.💁 Possible Solution
I understand that this might be tricky to solve as the
Row
is missing mouse events while the popover is open. Maybe a check on the mouse position could be done after thePopover
has been closed?🔦 Context
No response
🖥️ Steps to Reproduce
React.Aria.Table.Row.Hover.+.Popover.mp4
https://codesandbox.io/s/purple-pond-qssgxg
Version
1.3.3
What browsers are you seeing the problem on?
Chrome, Microsoft Edge
If other, please specify.
No response
What operating system are you using?
macOS
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response
The text was updated successfully, but these errors were encountered: