Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scales.html not loading in production #237

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

karstens
Copy link
Contributor

@karstens karstens commented Mar 19, 2024

Description

Motivation

  • Issue does not happen in parcel dev mode, but did when run in production. Also during fixing the issue, parcel or moon did cache the buggy code. We should make sure, that the cache is cleared before building the UI. Remote and locally.

Screenshots

To-do list

  • This pull request is ready to merge.

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: 5d204b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adobe/leonardo-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GarthDB
Copy link
Member

GarthDB commented Mar 19, 2024

Run report for 5d204b9b

Total time: 18.8s | Comparison time: 17.5s | Estimated loss: 1.3s (7.0% slower)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupNodeTool(~20.11) 1s Skipped
🟩 InstallNodeDeps(~20.11) 8.4s Passed
🟩 SyncNodeProject(contrast-colors) 0.2ms Passed
🟩 SyncNodeProject(ui) 0.3ms Passed
🟩 RunTask(ui:makeDistDir) 31.7ms Passed
🟩 RunTask(ui:copyCNAME) 56.6ms Passed
🟩 RunTask(ui:copyUIIcons) 57.6ms Passed
🟩 RunTask(ui:copyWorkflowIcons) 40.5ms Passed
🟩 RunTask(ui:buildSite) 9.3s Passed
Touched files
.changeset/calm-starfishes-thank.md
docs/ui/README.md
docs/ui/moon.yml
docs/ui/src/js/createHtmlElement.js

@karstens karstens requested a review from GarthDB March 19, 2024 11:46
Copy link
Member

@GarthDB GarthDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karstens, Could you add a Changeset?

@karstens karstens requested a review from GarthDB March 21, 2024 09:18
@GarthDB GarthDB merged commit b5dbb3d into main Mar 21, 2024
3 checks passed
@GarthDB GarthDB deleted the karstens/fix--scales-not-loading-in-production branch March 21, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leonardo Color Scales interface not loading
2 participants