Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove SAPC-APCA from git submodules #234

Closed
wants to merge 28 commits into from

Conversation

karstens
Copy link
Contributor

  • contrast-colors uses apca-w3 as npm dependency already

Description

  • project uses npm dependency instead of git submodule

Motivation

  • code cleanup

Screenshots

To-do list

  • This pull request is ready to merge.

GarthDB and others added 28 commits December 21, 2023 15:11
* replaced yarn with pnpm everywhere
* make nodeJS version flexible
* fix some typos
* test linking via pnpm
I should have had this when I added Husky initially.
feat: add prettier config and test npm script
* contrast-colors uses apca-w3 as npm dependency already
Copy link

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: a7216dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@adobe/leonardo-contrast-colors Patch
@adobe/leonardo-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karstens karstens requested a review from GarthDB March 13, 2024 11:42
@GarthDB
Copy link
Member

GarthDB commented Mar 13, 2024

Run report for b79f0ad0

Total time: 18.3s | Comparison time: 17s | Estimated loss: 1.4s (7.5% slower)

Action Time Status Info
🟩 SyncWorkspace 0ms Passed
⬛️ SetupNodeTool(~20.11) 1s Skipped
🟩 InstallNodeDeps(~20.11) 7.7s Passed
🟩 SyncNodeProject(contrast-colors) 0.1ms Passed
🟩 SyncNodeProject(ui) 0.3ms Passed
🟩 RunTask(ui:makeDistDir) 31.8ms Passed
🟩 RunTask(ui:copyCNAME) 27.4ms Passed
🟩 RunTask(ui:copyUIIcons) 65.9ms Passed
🟩 RunTask(ui:copyWorkflowIcons) 56.9ms Passed
🟩 RunTask(ui:buildSite) 9.5s Passed
Touched files
.gitmodules
docs/ui/src/images/Artboard – 10.png

Base automatically changed from monorepo to main March 14, 2024 17:08
@GarthDB GarthDB force-pushed the main branch 5 times, most recently from 5f0c5be to df525d8 Compare March 14, 2024 23:36
@GarthDB GarthDB force-pushed the karstens/fix--git-submodule branch from b79f0ad to a7216dc Compare March 14, 2024 23:36
@karstens karstens closed this Mar 15, 2024
@karstens karstens deleted the karstens/fix--git-submodule branch March 15, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants