Fix usage of contrast-colors with commonjs and esm #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs: launch prep
Merge branch 'master' of github.com:adobe/leonardo
style: fixed issue with tabs indicator color fallback
feat: adding link to demo app in UI
Bumps [serialize-to-js](https://github.com/commenthol/serialize-to-js) from 3.0.0 to 3.0.2. - [Release notes](https://github.com/commenthol/serialize-to-js/releases) - [Commits](commenthol/serialize-to-js@v3.0.0...v3.0.2) Signed-off-by: dependabot[bot] <[email protected]>
style: Updated demo app to a calendar with more colors to demonstrate
style: updated styles of links
…ize-to-js-3.0.2 build(deps): bump serialize-to-js from 3.0.0 to 3.0.2
feat: colorscale as HTML Canvas
style: dropdown width override to correct width
- @adobe/[email protected] - @adobe/[email protected]
* added tests and updated getContrast function for APCA support * feat: updated support for APCA with tests and UI
* added tests and updated getContrast function for APCA support * feat: added parameter support (URL) for formula
* added tests and updated getContrast function for APCA support * fix: polarity switch in APCA
- @adobe/[email protected] - @adobe/[email protected]
…ed with less than 100% saturation (adobe#172)
- @adobe/[email protected] - @adobe/[email protected]
* added initial form fill for contrast. WCAG 2 formula works * added apca to bulk contrast Co-authored-by: Nathan Baldwin <[email protected]>
1 task
|
ping :) |
|
Anything wrong with this? Otherwise it would be great to merge this before conflicts are introduced or it becomes incomplete |
|
I was exploring the |
|
Would be appreciated if you or anyone else could take this over. As this PR was completely ignored, while development and releases happened, I've given up. |
|
This is still sorely needed |
GarthDB
force-pushed
the
main
branch
8 times, most recently
from
500acc1
to
ed3e3c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix usage as commonjs and esm module and add dependencies of
contrast-colorsto itspackage.json.As
.mjsfile extension is used for esm module files, the moduletypecan be set tocommonjs, which is what.jsfiles are.The
mainproperty ofpackage.jsonshould now point to the commonjs file indist/-index.jswas not working at all, as there isindex.mjsin the package root andindex.jsonly in the dist folder.The
moduleproperty obviously can point toindex.mjs.The
exportsproperty apparently needsimportandrequireto make importing and requiring the module work, I tried all sorts of other combinations, but this was the only variant that worked for me.I had to adjust the imports, I assume bundlers handle it without the file extension, but using it in vanilla node requires the file extension:
.mjsin this case - independently of thetypeproperty inpackage.json.I did not update the lock files as I'm not sure where and how exactly I should run
npmoryarn- also my versions seemed newer than yours and caused a huge amount of changes in those files, so maybe it's better if you do it yourselves.See https://antfu.me/posts/publish-esm-and-cjs for further reference
Motivation
With version alpha.16 we're not able to use
leonardo-contrast-colorsanymore in a NodeJS script that's still using commonjs modules.Fixes #173
Screenshots
To-do list