Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert build to ruff and run formatting #43

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

bluesliverx
Copy link
Contributor

Description

The ruff module replaces pylint, pycodestyle and adds formatting as well. I have also added pre-commit checks for this project.

Related Issue

Motivation and Context

We often run into build errors from pylint/pycodestyle problems during the build, where a pre-commit check will find this much faster. Ruff itself is 100-150x faster than pylint and pycodestyle and does nearly all of the same things.

How Has This Been Tested?

I ran the pre-commit locally to ensure everything is as it is should be.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bluesliverx bluesliverx merged commit 696a60f into adobe:main Dec 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants