Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for @starting-style #319

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

jantimon
Copy link

Description

Add support for @starting-style (see #318)

Related Issue

fixes #318

Motivation and Context

Allows parsing @starting-style (see #318)

How Has This Been Tested?

Added new test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project..
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

@holblin holblin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good 👍 let me add a bump version, changelog and release it 👍
Thanks a lot for the contribution!

@jantimon
Copy link
Author

jantimon commented Jun 5, 2024

Thank you for your quick support and for releasing this change :)

I created two upstream issues and prs to upgrade to @adobe/css-tools 4.4.0:

@jantimon jantimon deleted the feature/starting-style branch June 5, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using @starting-style CSS at-rule crashes the parser with "property missing ':'" error
2 participants