Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using NO_PROXY env variable #603

Open
morganwahbi opened this issue Mar 26, 2024 · 5 comments
Open

using NO_PROXY env variable #603

morganwahbi opened this issue Mar 26, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@morganwahbi
Copy link

Expected Behaviour

i would like to use NO_PROXY=ip,ip,ip,dns as env variable to not use http_proxy/https_proxy for certain dns/ip.

But in my case the NO_PROXY is not used and the cli just use the http/https proxy set.

Actual Behaviour

If i export NO_PROXY=adobeioruntime.net, and then run aio rt actions list i get :

 Datetime        Access   Kind     Version  Actions
 ─────────────── ──────── ──────── ──────── ─────────────────────────────────────────────────

where without proxy i have informations in the tab.

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

aio info

›   Warning: @adobe/aio-cli update available from 9.3.0 to 10.0.0.
 ›   Run npm install -g @adobe/aio-cli to update.

  System:
    OS: Linux 3.10 Red Hat Enterprise Linux 8.7 (Ootpa)
    CPU: (4) x64 Intel(R) Xeon(R) CPU E5-2640 v3 @ 2.60GHz
    Memory: 2.35 GB / 23.39 GB
    Shell: 4.4.20 - /bin/bash
  Binaries:
    Node: 14.18.3 - /usr/local/bin/node
    Yarn: Not Found
    npm: 6.14.11 - /usr/local/bin/npm
  Virtualization:
    Docker: Not Found
  npmGlobalPackages:
    @adobe/aio-cli: 9.3.0

  Proxies:
    http: proxy:80
    https: proxy:80 (scheme mismatch)
  CLI plugins:
    core:
      @adobe/aio-cli 9.3.0
      @adobe/aio-cli-plugin-app 10.7.2
      @adobe/aio-cli-plugin-app-templates 1.5.2
      @adobe/aio-cli-plugin-auth 3.2.1
      @adobe/aio-cli-plugin-certificate 1.0.1
      @adobe/aio-cli-plugin-config 4.0.1
      @adobe/aio-cli-plugin-console 4.1.0
      @adobe/aio-cli-plugin-events 3.3.1
      @adobe/aio-cli-plugin-info 3.0.1
      @adobe/aio-cli-plugin-runtime 6.2.0
      @adobe/aio-cli-plugin-telemetry 1.2.0
      @oclif/plugin-autocomplete 1.4.6
      @oclif/plugin-help 5.2.20
      @oclif/plugin-not-found 2.4.3
      @oclif/plugin-plugins 2.4.7
      @oclif/plugin-warn-if-update-available 2.1.1
    user:
    link:
    ```

#### Sample Code that illustrates the problem

#### Logs taken while reproducing problem
@shazron shazron added the enhancement New feature or request label Mar 27, 2024
@shazron
Copy link
Member

shazron commented Mar 27, 2024

@adobe/aio-cli-plugin-app@v12 should support NO_PROXY via an updated sub-dependency. v10 of the cli should include the latest code that should support his, so run npm install -g @adobe/aio-cli to upgrade.

@shazron
Copy link
Member

shazron commented Mar 27, 2024

note that this NO_PROXY support is only for any aio rt commands, in general, any other network communication in the cli will not honor this env variable without us adding support for it.

@aiojbot
Copy link

aiojbot commented Mar 27, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2919

@morganwahbi
Copy link
Author

I will try the 10.0.0, but in my case i dont just do aio rt commands but, i also build and deploy applications with aio cli, and somehow the deploy command seems to lie to me where it gave a success where the applications are not officially deployed. (cause of the proxy of course.)

SO if you can add support for it, it would be awesome. =)

Thanks for the reply, i will try to keep you inform of my tests

@aiojbot
Copy link

aiojbot commented Jun 28, 2024

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-3068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants