Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version-bump-publish.yml workflow - new tag is not pushed #492

Open
shazron opened this issue Aug 18, 2023 · 1 comment
Open

version-bump-publish.yml workflow - new tag is not pushed #492

shazron opened this issue Aug 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@shazron
Copy link
Member

shazron commented Aug 18, 2023

The workflow will push the new package.json version update, but it will not push the new tag itself.

For the new workflow, it should have an additional command git push --tags (blanket push of all new tags) since we don't know what the exact version is, unless we dynamically retrieve it for the command.

The template should be fixed as well: https://github.com/adobe/.github/blob/main/workflow-templates/version-bump-publish.yml

Unfortunately, we need to add this to every repo that we have, unless we create an Github Action that does what we need.

@shazron shazron added the bug Something isn't working label Aug 18, 2023
@aiojbot
Copy link

aiojbot commented Aug 18, 2023

JIRA issue created: https://jira.corp.adobe.com/browse/ACNA-2487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants