Fixes for Catalina (10.14+) #2
Conversation
…precated in macOS 10.12
…precated in macOS 10.12
…, 'NSNumericPadKeyMask' deprecated
…precated in macOS 10.12
…cated in macOS 10.12
…dDataWithRootObject' deprecated
…'setAccessoryView:' deprecated
|
Thanks for this work! Can you remove the old code, rather than commenting it out? Also, you can delete the explanations of what is deprecated from the code. If you want it documented, I'd put that info the commit message. If you can make these changes I'll accept the pull request. Btw, please modify your existing patches rather than adding more followon patches with these adjustments. Thanks again! |
FPDocumentView.m
Outdated
| /* | ||
| TODO | ||
| Fix the error: | ||
| Sending 'NSPoint' (aka 'struct CGPoint') to parameter of incompatible type 'NSRect' (aka 'struct CGRect') | ||
| [[_scrollView contentView] scrollToPoint: | ||
| [[_scrollView contentView] constrainBoundsRect:viewOrigin]]; | ||
| */ | ||
| [[_scrollView contentView] scrollToPoint:viewOrigin]; | ||
|
|
There was a problem hiding this comment.
What is left to do for this TODO? Would it be possible for you to do the fix?
There was a problem hiding this comment.
I really don't know what I did here ;-)
Once I removed the constrainBoundsRect I get rid of the error but what are the implication? No idea.
|
This is awesome, many thanks! Any chance to get a compiled download for testing? |
|
I'm interested too...how do I even attempt to compile this on my 10.13.6 Mac OS ? are there any instructions anywhere ? |
|
Is there a plan to merge it to master? |
|
Many thanks for this update. I have successfully Build a FormulatePro app on macOS Catalina 10.15.7 (19H114). |
|
uby1, can you share a dmg of your build or a tar file of the source you compiled ? |
Sure, but I had to sign it for "Runing Locally" so no sure it is work outside my own environment. Let me know if you get the files correctly and which one are running (.dmg) or you could successfully compile by yourself in Xcode. |
|
the .dmg works ! I'll report when I use your emaV modified Xcode project... Happy New Year! |
|
Great! Enjoy! |
|
Awesome thanks @emaV for the fix. |
I've been using FormulatePro (love it, brilliant app) since years and recently I had to update my Mac to Catalina.
This is my first attempt. I updated the code to remove the various deprecations and seems to build on my Mac. Not tested extensively though.