Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for LRS rejecting null values #240

Open
garemoko opened this issue Oct 9, 2018 · 2 comments
Open

test for LRS rejecting null values #240

garemoko opened this issue Oct 9, 2018 · 2 comments

Comments

@garemoko
Copy link

garemoko commented Oct 9, 2018

We found a (recent) statement in Watershed containing the following property:

    "correctResponsesPattern": [ 
        null 
      ]

We should have rejected this because the LRS is required to reject statements with null values outside of extensions: https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#lrs-requirements

We're going to fix the issue in Watershed, but since we are passing the conformance test my assumption is that the test suite is not checking that the LRS rejects statements containing null values, or at least is not checking this particular property.

Do we know what the test suite tests in this regard? Should it test null values in every possible property? Should it test more than it tests now?

@vbhayden
Copy link
Member

vbhayden commented Nov 7, 2018

I can't find where / if this specific case is checked by the suite, so I'm assuming it isn't.

As for that case, should an array with a single value null be considered null itself?

@garemoko
Copy link
Author

garemoko commented Nov 7, 2018

no, but it's still a null value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants