Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Entry.php #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Entry.php #93

wants to merge 1 commit into from

Conversation

draev
Copy link

@draev draev commented Aug 25, 2015

The last array index with X elements will be X-1

@draev
Copy link
Author

draev commented Sep 1, 2015

any comments about this fix ?

it really meaningful to fix it asap, when you handle php warnings as exceptions...

@rnowosielski
Copy link

Are you planning to merge this ? I was trying to use the lib but this bug makes it impossible to use for my purpose.

@rootpd
Copy link

rootpd commented Sep 19, 2015

+1 for merging. there really was a bug, this oneliner fixes it.

@juvinious
Copy link

^ Fourthed, please merge. Thanks.

@igorrynkovoy
Copy link

Please merge 👍

@aka-toxa
Copy link

lgtm 👍

@melya
Copy link

melya commented Sep 22, 2015

+1

1 similar comment
@andreyctkn
Copy link

👍

@arodik
Copy link

arodik commented Sep 22, 2015

great 👍

@strebl
Copy link

strebl commented Sep 22, 2015

Don't expect any help here... Switch to Adldap2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muchar muchar muchar approved these changes

@datatim datatim datatim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.