Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unlink seed" + "Fixed seed" not working #535

Open
tpsjr7 opened this issue Jun 21, 2023 · 12 comments · May be fixed by #552
Open

"Unlink seed" + "Fixed seed" not working #535

tpsjr7 opened this issue Jun 21, 2023 · 12 comments · May be fixed by #552

Comments

@tpsjr7
Copy link

tpsjr7 commented Jun 21, 2023

I pulled main on 525ee62

To reproduce:

Check "unlink seed" and "fixed seed"
Make an image with a fixed seed.

prompt: a __adj__ cat

seed: 102

Set "Batch Count" to 4.

I should see 4 new images all with seed 102 as it used to, but with different adjectives like:

  • seed 102: a bad cat
  • seed 102: a nice cat
  • seed 102: a big cat
  • seed 102: a small cat

Currently it generates 4 new prompts but different seeds

  • seed 102: a bad cat
  • seed 103: a nice cat
  • seed 104: a big cat
  • seed 105: a small cat
adieyal added a commit that referenced this issue Jul 8, 2023
These are now returned from the get_seeds function which decides whether if should be the same as image seeds or generated separately. Fixes #535
@adieyal adieyal linked a pull request Jul 8, 2023 that will close this issue
adieyal added a commit that referenced this issue Jul 8, 2023
These are now returned from the get_seeds function which decides whether if should be the same as image seeds or generated separately. Fixes #535
adieyal added a commit that referenced this issue Aug 13, 2023
These are now returned from the get_seeds function which decides whether if should be the same as image seeds or generated separately. Fixes #535
@Voltschrat
Copy link

Still having this issue in the latest version (39c06b3).
"Fixed seed" seems to break whenever "Unlink seed from prompt" is enabled, and "Combinatorial generations" is disabled.
It does work in conjunction with combinatorial generation, but that's not always what you want.
Just "Fixed seed", but without "Unlink seed from prompt" also seems to work and not increment the seed, but then of course you always get the same image, which sadly renders this option useless for anything but combinatorial batches at the moment :(

maybe this additional information helps

@evanerichards
Copy link

I can confirm I'm running into the same problem. If I turn on unlink seed from prompt the seed still increments by +1 each iteration. I've never got it to work even with "combinatorial generations" turned on.

@a-l-e-x-d-s-9
Copy link

Any chance this issue will be fixed?

@evanerichards
Copy link

Any chance this issue will be fixed?

I don't remember how I had dynamic prompts set up before, but it seems like this issue may be resolved now?

@a-l-e-x-d-s-9
Copy link

@evanerichards
The problem is still in the main branch.
You may be using an older version or tag.

@OTP275
Copy link

OTP275 commented Dec 6, 2023

I seem to recall being able to do this at some point but maybe i didnt notice because every version i have tested has this problem including the most recent update. this issue was created in june, so i guess for some reason this is being ignored?
are there any forks that fixed this yet?

@evanerichards
Copy link

evanerichards commented Dec 6, 2023

I seem to recall being able to do this at some point but maybe i didnt notice because every version i have tested has this problem including the most recent update. this issue was created in june, so i guess for some reason this is being ignored? are there any forks that fixed this yet?

It's working for me. I don't know what to tell anyone else, but it wasn't working originally so I posted here (months ago) asking for a fix, and it started working with the latest version when I upgraded mid-November.

@OTP275
Copy link

OTP275 commented Dec 6, 2023

I seem to recall being able to do this at some point but maybe i didnt notice because every version i have tested has this problem including the most recent update. this issue was created in june, so i guess for some reason this is being ignored? are there any forks that fixed this yet?

It's working for me. I don't know what to tell anyone else, but it wasn't working originally so I posted here (months ago) asking for a fix, and it started working with the latest version when I upgraded mid-November.

what version did it start working on?

@Kexus
Copy link

Kexus commented Dec 8, 2023

I just tested with the latest version and its still broken

  • Combinatorial generation OFF
  • Unlink seed ON
  • Fixed seed ON

This results in a unique seed and unique prompt for each image in the batch

Version 2817d2ed

@OTP275
Copy link

OTP275 commented Dec 8, 2023

I can confirm version 2817d2ed still doesnt work. tested on a fresh install and on a second device

@tpsjr7
Copy link
Author

tpsjr7 commented Dec 21, 2023

I had to reinstall AUTOMATIC1111, if you value this fix above other newer features, I was able to work around this by manually checking out the checkout bug/fixed-seeds branch from here #552

cd stable-diffusion-webui/extensions/sd-dynamic-prompts
git fetch --all
git checkout bug/fixed-seeds

then restart.

Maybe deleting the extension then using "Install from URL" and specifying the bug/fixed-seeds branch might work too.

@spaciousmind
Copy link

I had to reinstall AUTOMATIC1111, if you value this fix above other newer features, I was able to work around this by manually checking out the checkout bug/fixed-seeds branch from here #552

cd stable-diffusion-webui/extensions/sd-dynamic-prompts
git fetch --all
git checkout bug/fixed-seeds

then restart.

Maybe deleting the extension then using "Install from URL" and specifying the bug/fixed-seeds branch might work too.

I had the same problem, using forge.
I simply did the commands in git as you suggested and restarted and now it works! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants