-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: frontend #483
base: main
Are you sure you want to change the base?
refactor: frontend #483
Conversation
3d77b08
to
ab8126e
Compare
e5540ba
to
5f4bbee
Compare
Just as a note for later: The same needs to be done for the customer-center |
debab36
to
37abeff
Compare
e5bd6e1
to
dc1cf6b
Compare
aeac3af
to
76dc6c8
Compare
datepicker tests: had to be adjusted because the date selection was changed to start on monday other tests: had to be adjusted because of how ember-responsive works
0219bfe
to
7ea6673
Compare
Thank you @c0rydoras! I like a lot of the subtle changes, like the more compact timeline. Also, that the week now starts with Monday. And many more small details. The theme, though, seems a bit aggressive to me. I don't know why. Colors and contrasts, probably. The old one is more pleasing for the eye. The rather big animation, while waiting for results, is quite big and triggers something within me with its heavy blinking. I like how things had the same size in the old UI. Sizing seems more random in the new one. See my screenshots. Also with my external monitor some texts seem granular. This is partly due to the bad and old monitor. It's okay on my notebook. But the old UI on the same old monitor had sharp readings. Cheers, Thomas |
Thanks for the hard work! I like that some things are more compact, like the timeline. The new UI also seems snappier generally. Unfortunately, dark reader looks quite a bit worse now, would be interested in seeing that experimental dark mode. It seems like higher contrast was chosen, this makes the whole look more aggressive, not sure this can be avoided. The loading animations also seem quite large now. The font sizes seems to be generally bigger, making the new UI (light) look busier than before (dark). It also feels like more different sizes are used, would be nice if it was more streamlined. |
I think the problem with using our corporate design colors as the basis for the UI colors is that those colors have been chosen with grabbing someones attention in mind, while UIs work better with more dim colors. On the left we have the new blue primary color with hsv(223.58, 69.74%, 59.61%) and on the right the old primary color with hsv(216.09, 58.45%, 85.88%). While the hue (color) is nearly the same the saturation of the new primary color is higher and it is darker. If we keep the hue the same and reduce the saturation and brightness to the same level as the old UI color we end up with a much calmer color: |
How big is the loading thingy? IIRC I alr made it smaller (maybe its not on test yet) --edit: looks like I haven't pushed that yet |
d2b42b9
to
920ee65
Compare
dark
class to<html>
)