Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: frontend #483

Open
wants to merge 101 commits into
base: main
Choose a base branch
from
Open

Conversation

c0rydoras
Copy link
Collaborator

@c0rydoras c0rydoras commented Oct 2, 2024

  • use adfinis ci (colors)
  • get rid of adcssy.scss (and all other scss)
  • support for dark mode (very experimental, add dark class to <html>)
  • fix some bugs
    • comments can only be deleted if they exist
    • the save button is disabled if the report is invalid
    • some visual bugs

@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 3 times, most recently from 3d77b08 to ab8126e Compare October 2, 2024 08:34
@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 4 times, most recently from e5540ba to 5f4bbee Compare October 2, 2024 10:10
@derrabauke
Copy link
Contributor

Just as a note for later: The same needs to be done for the customer-center

@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 10 times, most recently from debab36 to 37abeff Compare October 4, 2024 12:18
@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 8 times, most recently from e5bd6e1 to dc1cf6b Compare October 21, 2024 07:31
@c0rydoras c0rydoras force-pushed the refactor/frontend/css branch 2 times, most recently from aeac3af to 76dc6c8 Compare October 28, 2024 13:35
@tk0e
Copy link
Member

tk0e commented Nov 13, 2024

Thank you @c0rydoras!

I like a lot of the subtle changes, like the more compact timeline. Also, that the week now starts with Monday. And many more small details.

The theme, though, seems a bit aggressive to me. I don't know why. Colors and contrasts, probably. The old one is more pleasing for the eye. The rather big animation, while waiting for results, is quite big and triggers something within me with its heavy blinking.

I like how things had the same size in the old UI. Sizing seems more random in the new one. See my screenshots.

Also with my external monitor some texts seem granular. This is partly due to the bad and old monitor. It's okay on my notebook. But the old UI on the same old monitor had sharp readings.

Cheers, Thomas

Bildschirmfoto vom 2024-11-13 13-50-41
Bildschirmfoto vom 2024-11-13 13-51-32

@strobeflash
Copy link

Thanks for the hard work!

I like that some things are more compact, like the timeline. The new UI also seems snappier generally.

Unfortunately, dark reader looks quite a bit worse now, would be interested in seeing that experimental dark mode. It seems like higher contrast was chosen, this makes the whole look more aggressive, not sure this can be avoided. The loading animations also seem quite large now.

Screenshot From 2024-11-13 14-42-39
Screenshot From 2024-11-13 14-42-29

The font sizes seems to be generally bigger, making the new UI (light) look busier than before (dark). It also feels like more different sizes are used, would be nice if it was more streamlined.

Screenshot From 2024-11-13 14-37-57
Screenshot From 2024-11-13 14-37-32

Screenshot From 2024-11-13 14-40-34
Screenshot From 2024-11-13 14-40-16

@tongpu
Copy link
Member

tongpu commented Nov 13, 2024

I just stumbled over this cut off view in the state panel of the filter sidebar on the Analysis tab:

image

@tongpu
Copy link
Member

tongpu commented Nov 13, 2024

The theme, though, seems a bit aggressive to me. I don't know why. Colors and contrasts, probably. The old one is more pleasing for the eye. The rather big animation, while waiting for results, is quite big and triggers something within me with its heavy blinking.

I think the problem with using our corporate design colors as the basis for the UI colors is that those colors have been chosen with grabbing someones attention in mind, while UIs work better with more dim colors.

image

On the left we have the new blue primary color with hsv(223.58, 69.74%, 59.61%) and on the right the old primary color with hsv(216.09, 58.45%, 85.88%). While the hue (color) is nearly the same the saturation of the new primary color is higher and it is darker. If we keep the hue the same and reduce the saturation and brightness to the same level as the old UI color we end up with a much calmer color:

image

@c0rydoras
Copy link
Collaborator Author

c0rydoras commented Nov 13, 2024

How big is the loading thingy? IIRC I alr made it smaller (maybe its not on test yet)

--edit: looks like I haven't pushed that yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: Update colors [REFACTOR]: get rid of adcssy.scss
8 participants