We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I think #95 introduced a regression where checkbox elements don't use a span wrapped label anymore.
https://github.com/adfinis-sygroup/ember-validated-form/pull/95/files#diff-3fdbc85ba77b90bb068fe83da64dee87L85 removed wrapping the checkbox label in a span by introducing a validated-label that is simply echoing the {{label}}.
validated-label
{{label}}
I think it's my fault for not adding a test that checks that checkbox labels are also wrapped in a span.
There's probably a similar issue where validated-label isn't used for radio inputs. Meaning you can't customize the label there.
There are various possible options to solve this:
validated-input
wrapped
true
I can open a PR if we find a solution
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I think #95 introduced a regression where checkbox elements don't use a span wrapped label anymore.
https://github.com/adfinis-sygroup/ember-validated-form/pull/95/files#diff-3fdbc85ba77b90bb068fe83da64dee87L85 removed wrapping the checkbox label in a span by introducing a
validated-label
that is simply echoing the{{label}}
.I think it's my fault for not adding a test that checks that checkbox labels are also wrapped in a span.
There's probably a similar issue where
validated-label
isn't used for radio inputs. Meaning you can't customize the label there.There are various possible options to solve this:
validated-input
validated-label
, which means all validated-labels will change orwrapped
attribute tovalidated-label
which will be set totrue
for uses in checkbox or radio inputsI can open a PR if we find a solution
The text was updated successfully, but these errors were encountered: