Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spoor schema throws errors #3344

Closed
ptabak opened this issue Dec 1, 2022 · 3 comments
Closed

Spoor schema throws errors #3344

ptabak opened this issue Dec 1, 2022 · 3 comments

Comments

@ptabak
Copy link

ptabak commented Dec 1, 2022

Trying to build a newly created course with grunt build throws the following warning which results in the task aborting prematurely:

Running "schema-defaults" task
Warning: src/extensions/adapt-contrib-spoor/properties.schema: Unexpected token c in JSON at position 12082 Use --force to continue.

Replacing default adapt-contrib-spoor extension with v5.2.1 fixes the issue.

Your environment

  • Adapt Framework v5.22.11
  • macOS 12.4
  • node v14.21.1

Steps to reproduce

Create a new course with adapt create course
Switch to newly created course directory and run grunt build

Expected behaviour

Course should build successfully

Actual behaviour

Grunt build task aborts due to warnings

@NotMyself
Copy link

NotMyself commented Dec 6, 2022

This is the root cause of the build issue described in adaptlearning/adapt-cli#181

Digging into the history, it looks like this commit added lines using optional chaining.

Optional chaning was added to uglify-js in version v3.13.6.

The current version of grunt-contrib-uglify has a dependency on uglify-js v3.16.1.

I was able to get around this issue by adding a direct dependency on a later version of uglify-js to the package.json of my project.

npm install uglify-js

This installs uglify-js 3.17.4 for me.

@chris-steele
Copy link
Contributor

Good spot and thank you. Will be fixed by #3352

@oliverfoster
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants