Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added support for _canShowCorrectness #147

Merged
merged 15 commits into from
Oct 28, 2024
Merged

New: Added support for _canShowCorrectness #147

merged 15 commits into from
Oct 28, 2024

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Sep 18, 2024 •
edited
Loading

part of adaptlearning/adapt_framework#3597

Allows option _canShowCorrectness instead of _canShowModelAnswer, to replace the associated toggle button and display correctness directly on the component.

New

  • Added support for _canShowCorrectness
  • Show a comma separated list of correct options when _canShowCorrectness true
  • .show-correctness widget class appended for consistency with other question components. Note, there's no associated styling currently.
  • Default prefix text added for the correct options. correctAnswerPrefix and correctAnswersPrefix added to support both single and multiple correct answers. For now this just exists in course _globals but could later add a component level override if needed. Or move these to Core if shared across question components. Prefix is optional.

textinput_prefix

Requires

ref adaptlearning/adapt-contrib-core#582

@kirsty-hames
show a comma separated list of correct options when _canShowCorrectne…
f8a59b4 
…ss true

- 'show-correctness' widget class appended for consistency with other question components
@kirsty-hames kirsty-hames self-assigned this Sep 18, 2024
joe-allen-89
joe-allen-89 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected 👍

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 28, 2024
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames kirsty-hames merged commit 3e0305f into master Oct 28, 2024
@kirsty-hames kirsty-hames deleted the issue/3597 branch October 28, 2024 12:11
github-actions bot pushed a commit that referenced this pull request Oct 28, 2024
@semantic-release-bot
Chore(release): 7.3.0 [skip ci]
19e0635 
# [7.3.0](v7.2.13...v7.3.0) (2024-10-28)

### New

* Added support for _canShowCorrectness  (#147) ([3e0305f](3e0305f)), closes [#147](#147)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89