Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Change order of adapt create course steps to put branch/tag before course (fix #207) #209

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Update: Change order of adapt create course steps to put branch/tag before course (fix #207) #209

merged 1 commit into from
Aug 7, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Aug 5, 2024 •
edited
Loading

Fix #207

Update

  • Change the order of adapt create course steps to put branch/tag step before name step.

Testing

Run adapt create course. You should see the steps in this order:

? type: course
? branch/tag v5.40.6
? name (my-adapt-course)

@swashbuck swashbuck self-assigned this Aug 5, 2024
joe-replin
joe-replin approved these changes Aug 5, 2024
View reviewed changes
Copy link

@joe-replin joe-replin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just mildly miffed by this today. Thank you for identifying.

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@swashbuck swashbuck merged commit 5316c10 into master Aug 7, 2024
2 checks passed
@swashbuck swashbuck deleted the issue/207 branch August 7, 2024 14:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-replin joe-replin joe-replin approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

Assignees

@swashbuck swashbuck

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change setup question order to put "branch/tag" before "name"
4 participants
@swashbuck @joe-replin @oliverfoster @cahirodoherty-learningpool