Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will not register private: true bower.json #200

Closed
oliverfoster opened this issue Oct 4, 2023 · 1 comment · Fixed by #201
Closed

Will not register private: true bower.json #200

oliverfoster opened this issue Oct 4, 2023 · 1 comment · Fixed by #201
Assignees

Comments

@oliverfoster
Copy link
Member

Subject of the issue

By adding automated releases to each plugin, and causing the bower.json to be a copy of the package.json and in including "private": true in the package.json to prevent the automation scripts publishing on npm, the bower library will now not register the plugins, due to these lines in the bower library https://github.com/bower/bower/blob/a0d44443245cbe52f3f0bd90c3f41274bc040c7a/lib/commands/register.js#L44-L49

As we register plugins by hand, it should be possible to register plugins in our bower repos even if they are marked as private.

Example package.json:

  "private": true,
  "scripts": {
    "postversion": "cp package.json bower.json"
  },
@oliverfoster oliverfoster self-assigned this Oct 4, 2023
joe-allen-89 pushed a commit that referenced this issue Oct 17, 2023
* Fix: Allow register of private repos (fixes #200)

* Update register.js
github-actions bot pushed a commit that referenced this issue Oct 17, 2023
## [3.1.4](v3.1.3...v3.1.4) (2023-10-17)

### Fix

* Allow register of private repos (fixes #200) (#201) ([11723bd](11723bd)), closes [#200](#200) [#201](#201) [#200](#200)
@github-actions
Copy link

🎉 This issue has been resolved in version 3.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant