Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot update non-prefixed plugin #121

Open
tomgreenfield opened this issue Mar 26, 2020 · 5 comments
Open

Cannot update non-prefixed plugin #121

tomgreenfield opened this issue Mar 26, 2020 · 5 comments
Labels

Comments

@tomgreenfield
Copy link
Contributor

When trying to update the core-bundled Vanilla theme:

$ adapt update contrib-vanilla

No valid targets specified (please check spelling and case).

This only works if I type the entire name, adapt-contrib-vanilla.

@oliverfoster
Copy link
Member

should we support this? would it not be better just to have absolute names?

@tomgreenfield
Copy link
Contributor Author

Just mentioning because it's a regression – I never bother to type the adapt- prefix, as per the README.

@oliverfoster
Copy link
Member

Cool. I'd be in favour of dropping this to simplify the future requirements.

@moloko
Copy link
Contributor

moloko commented Mar 26, 2020

it does say here that the 'adapt' prefix is optional

@oliverfoster
Copy link
Member

I'm suggesting it shouldn't, npm won't support optional prefixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants