Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite loop in columnizeIt where destroyable items are empty #197

Open
zeffrin opened this issue Jul 30, 2015 · 1 comment
Open

Infinite loop in columnizeIt where destroyable items are empty #197

zeffrin opened this issue Jul 30, 2015 · 1 comment

Comments

@zeffrin
Copy link

zeffrin commented Jul 30, 2015

Ran into issue with infinite loop on the while at line 532.

$destroyable.contents().length gets stuck on 2, and both of those items are empty
Then on line 564 goes in here and appends more emptyness to $col.contents(), goes in every time etc

Hacked a fix as so, insert line 585 (end of while loop)
if($destroyable.contents().length > 0)
{
for(int i = $destroyable.contents().length - 1; i >= 0; i--)
{
if($destroyable.contents(i).length == 0)
$destroyable.contents.remove(i);
}
}

I would submit pull request but I suspect there's going to be a root cause/better place to fix this

Thanks

@zeffrin
Copy link
Author

zeffrin commented Jul 30, 2015

ok that fix isn't right actually, should've been var there but not only that..

I'm having same problem again now except both destroyable.contents() hold 27 non ascii chars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant