Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccurate error mesage for invalid index #2

Open
adammangzijun opened this issue Nov 17, 2023 · 1 comment
Open

Inaccurate error mesage for invalid index #2

adammangzijun opened this issue Nov 17, 2023 · 1 comment

Comments

@adammangzijun
Copy link
Owner

adammangzijun commented Nov 17, 2023

image.png

It is technically the correct format just that the index given is not valid, as such I would say this error message is not as accurate.

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 20, 2023

Team's Response

Hello, thank you for your feedback. As you rightly mentioned, it is the correct format just that the index given is not valid! We have called out in the UG that if the index is not a positive integer, invalid command format will be the error message! Hence, this matches the expected output and we do not consider it as a bug.

Screenshot 2023-11-20 at 1.13.11 AM.png

However, we do acknowledge that the specificity of the error message can be improved, and this will be done in the future as specified under Planned Enhancements! We will classify this as NotInScope to provide some credit to you for identifying this area of improvement which we will be working on in the future.

image.png

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants