Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect representation of if else in the activity diagram #16

Open
adammangzijun opened this issue Nov 17, 2023 · 1 comment
Open

Comments

@adammangzijun
Copy link
Owner

adammangzijun commented Nov 17, 2023

image.png

There should be a [yes] or [no] like in this given example:

image.png

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 21, 2023

Team's Response

Hello, thank you for your feedback. This has been noted in issue #5579. Thank you

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Activity diagram for DeleteCompanyCommand

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.



Screenshot 2023-11-17 at 5.19.50 PM.png

The "company exists?" node should be replaced with a diamond node, and the left condition should be [company exists], and the right condition should be [else].


[original: nus-cs2103-AY2324S1/pe-interim#5314] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for your feedback! We agree that it does not adhere to the UML convention. However, we believe that it does not impair user understanding of our diagram and does not confuse the user, thus we believe that it should be Severity.VeryLow.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

  • I disagree

Reason for disagreement: Rather than duplication, I would say that it is another issue in the developer guide, it is not the same diagram as mentioned in the other bug.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants