Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider refactor so that polygons have ownership over vertices #7

Open
adamconkey opened this issue Nov 1, 2024 · 0 comments
Open
Assignees
Labels

Comments

@adamconkey
Copy link
Owner

I originally designed things so that polygons did not own vertices. That was intentional so that multiple polygons could be created from the same set of vertices, and you'd have a common structure, VertexMap from which to retrieve them by name which would enable efficient retrieval. I realize now that may have been a mistake, it makes things more clunky when you want to load things from file, and creates more data structures than are probably necessary.

I'd like to at least try a version where ownership of vertices is on the polygons. If it feels more ergonomic in the code then I'll bring it to main and hope that implementing something else down the road doesn't necessitate something like my current setup 😅

@adamconkey adamconkey self-assigned this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant