[dart/en] updating the dart examples to work against dart 3.0 #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verhovsky
reviewed
May 13, 2024
| @@ -199,8 +201,8 @@ class GenericExample<T>{ | |||
| const example8List = ["Example8 const array"]; | |||
| const example8Map = {"someKey": "Example8 const map"}; | |||
| /// Declare List or Maps as Objects. | |||
| List<String> explicitList = new List<String>(); | |||
| Map<String,dynamic> explicitMaps = new Map<String,dynamic>(); | |||
| List<String> explicitList = <String>[]; //new List<String>() is now | |||
There was a problem hiding this comment.
Suggested change
| List<String> explicitList = <String>[]; //new List<String>() is now | |
| List<String> explicitList = <String>[]; |
I don't understand this comment.
verhovsky
reviewed
May 13, 2024
Comment on lines
161
to
+163
| new Example7Class().sayItFromInstance(); | ||
| //the new keyword is optional, so this is the same | ||
| Example7Class().sayItFromInstance(); |
There was a problem hiding this comment.
Suggested change
| new Example7Class().sayItFromInstance(); | |
| //the new keyword is optional, so this is the same | |
| Example7Class().sayItFromInstance(); | |
| Example7Class().sayItFromInstance(); |
6 tasks
verhovsky
reviewed
May 13, 2024
| if (a) { | ||
| print("true, a is $a"); | ||
| } | ||
| a = null; | ||
| if (a) { | ||
| if (a ?? false) { //if null count as false |
There was a problem hiding this comment.
Suggested change
| if (a ?? false) { //if null count as false | |
| if (a ?? false) { // if null count as false |
But this could be worded more clearly.
There was a problem hiding this comment.
actually, should just delete this example if "Boolean expressions support implicit conversions" is no longer true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[language/lang-code](example[python/fr-fr]or[java/en])