-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ESP-NOW Support #7470
Add ESP-NOW Support #7470
Conversation
Co-authored-by: Nick Moore <[email protected]> Co-authored-by: shawwwn <[email protected]> Co-authored-by: glenn20 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@microdev1 Thank you for taking this on! We certainly have gotten a lot of call for it.
I realize this is a draft, and you know there are things left to do, so many of my comments are more just to make a TODO list that can be checked off.
Targeting this for 9.0.0 might make sense, since then we can use ESP-IDF v5.0 from the start. I will set it to that milestone for now.
@microdev1 Thanks also for taking this on. I confess I couldn't work out where to get started porting this to circuitpython. If there is anything I can do to help, let me know. |
@glenn20 (and others) Sure, will let you know and thanks for all the work you have done already. 🙂
I am hoping this can be in |
We could do for 8.x.x. We are trying to close out 8.0.0 really soon, but we have a bunch of things for 8.x.x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for porting this over!
Do you want to keep it MP compatible?
While I'm not the port-er, I'd be interested in maintaining compatibility with the original module on MP. I'm happy to adopt agreed changes to the api into the MP module if required. |
@glenn20 Sounds good. I'd love your feedback on my inline comments then. |
I have reworked the API. There are still some changes to be made in the underneath implementation and a few checks to be run but the API will largely remain the same and I'd like to get your opinion on it. |
Hey this is cool, thanks @microdev1 and @glenn20 for picking it up and running with it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the |
- improve docs - use existing list methods - change `recv` to `read`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor doc fix, otherwise the API looks good. Thank you!
Co-authored-by: Scott Shawcroft <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me too!
ESP-NOW is a proprietary wireless communication protocol which supports direct communication between espressif devices.
This would be of particular interest for low-power wireless communication requirements.
This PR is based on the previous work by @nickzoic, @shawwwn, @glenn20 and contributions from @zoland, including:
Closes #3999.
Closes glenn20#4.