add Adafruit_USBD_CDC::ignoreFlowControl #459
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, the target application will not assert the DTR virtual line, thus preventing writing operations to succeed. For this reason, the Adafruit_USBD_CDC::ignoreFlowControl() method disables the connection’s state verification, enabling the program to write on the port, even though the data might be lost.
|
I'm pretty sure that these building failures were caused by these platforms with Adafruit_TinyUSB included, as their built-in tinyUSB lib didn't include functions I added. So I think it's ok to merge anyway. |
Adafruit_USBD_CDC::ignoreFlowcontrol added in 0672cb8 may only work for rp2040 for now. So add #ifdef to limit this method to rp2040 core only.
|
As #460 says, ignoring |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, the target application will not assert the DTR virtual line, thus preventing writing operations to succeed.
For this reason, the Adafruit_USBD_CDC::ignoreFlowControl() method disables the connection’s state verification, enabling the program to write on the port, even though the data might be lost.