Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map: attribution not fully responsive #961

Open
2 tasks done
wkyoshida opened this issue Sep 2, 2024 · 3 comments
Open
2 tasks done

map: attribution not fully responsive #961

wkyoshida opened this issue Sep 2, 2024 · 3 comments
Labels
bug Something isn't working hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@wkyoshida
Copy link
Member

Terms

Behavior

Noticed that the map attribution is not quite fully responsive. The following main points were observed:


  • In dark mode, parts of the attribution are unreadable due to the text color:

image

..which was unfortunately overlooked, as that wasn't the case in local development and in the preview for PR #949:

image


  • Depending on screen size, the attribution can also sometimes sit on top of the Clear directions [x] custom control that we have on the bottom-left corner of the map:

image

..on this point, something that I'm considering is actually moving the Clear directions [x] custom control. Perhaps it could make sense to place it right under the route profile toggle button? The protruding size of the custom control might also not be an issue if a button to hide it is also implemented (as proposed in #960 - in the same vein as how the attribution control works).


  • Finally, not quite a fan of how the attribution wraps to fit in the text honestly... As we see in the below screenshot:

image
..only the word France is pushed down to the second line to fit everything. It could be more interesting if that entire segment of the attribution had been pushed down, e.g. in this case, CyclOSM tiles hosted by OpenStreetMap France so that the attribution might have looked something like:

MapLibre | © OpenStreetMap contributors |
CyclOSM tiles hosted by OpenStreetMap France

This point though is perhaps a little more tricky to wholy address. It also could simply be me being a bit too nitpicky 😅 so fully open to reconsideration. Mentioning this as I'm actually fine if this third point is set aside.

@wkyoshida wkyoshida added the bug Something isn't working label Sep 2, 2024
@andrewtavis andrewtavis added the help wanted Extra attention is needed label Sep 2, 2024
@andrewtavis
Copy link
Member

Maybe we can start with an initial discussion here 🤔 Do we absolutely need the full attribution, or can we do CyclOSM tiles by OSM France at the end? And as far as the attribution covering the clear directions control, maybe we can have it be hidden at the start and then it switches over to Click for directions as soon as any behavior that would clear the attribution takes place, with Click for directions being my suggestion in #960 :)

@wkyoshida
Copy link
Member Author

Do we absolutely need the full attribution, or can we do CyclOSM tiles by OSM France at the end?

I think that should be fine actually 👍 We would still be linking back to them, and just the OSM acronym is still quite recognizable.

maybe we can have it be hidden at the start

Sorry - not sure if I understood right. Did you mean here to initially hide the attribution control or the directions control?

@andrewtavis
Copy link
Member

I guess an initial PR for this could be to fix the attribution then :)

Did you mean here to initially hide the attribution control or the directions control?

Hide the directions control while the attributions control is visible, and then unhide when the user moves the map at all such that the attribution is hidden. Would also be nice if say clicking the attribution would hide the directions control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

2 participants