Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable previously-flaky tests #2583

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Re-enable previously-flaky tests #2583

wants to merge 7 commits into from

Conversation

nvoxland
Copy link
Contributor

@nvoxland nvoxland commented Sep 6, 2023

🚀 🚀 Pull Request

Impact

  • Test changes

Description

Re-enabing tests that were skipped due to them causing lockups. Seeing if code fixes have resolved the lock-up problems

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04% ⚠️

Comparison is base (d487171) 83.93% compared to head (fa8065e) 83.90%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2583      +/-   ##
==========================================
- Coverage   83.93%   83.90%   -0.04%     
==========================================
  Files         224      224              
  Lines       24533    24573      +40     
==========================================
+ Hits        20592    20618      +26     
- Misses       3941     3955      +14     
Flag Coverage Δ
unittests 83.90% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
deeplake/core/vectorstore/deeplake_vectorstore.py 97.50% <ø> (ø)
.../core/vectorstore/vector_search/dataset/dataset.py 98.00% <100.00%> (+0.37%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nvoxland nvoxland marked this pull request as draft September 6, 2023 21:06
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant