Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test against Rails 7.2 #318

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

ohbarye
Copy link
Contributor

@ohbarye ohbarye commented Aug 20, 2024

Hi, based on Rails 7.2 release, this pull request makes CI run tests against Rails 7.2.

Main changes are:

  • Add Rails 7.2 to test matrix
  • [chore] Add /gemfiles/vendor/ to .gitignore
    • I needed to run BUNDLE_GEMFILE=gemfiles/activerecord_7_2.gemfile bundle to debug test failures but it creates files under gemfiles/vendor. So I decided to let it ignore them.

It's needed to run `BUNDLE_GEMFILE=gemfiles/activerecord_7_2.gemfile bundle` to debug test failures but it creates files under `gemfiles/vendor`. So I decided to let it ignore them.
Copy link
Collaborator

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@kbrock kbrock merged commit f9ee4a4 into active-hash:master Aug 20, 2024
19 checks passed
@ohbarye ohbarye deleted the ci-against-rails-7-2 branch August 20, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants