Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Default field private #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make Default field private #314

wants to merge 1 commit into from

Conversation

kbrock
Copy link
Collaborator

@kbrock kbrock commented Jul 8, 2024

Followup to #312

I noticed that this is public.

We either want to make this private Or we want to to_sym` the field name.

I went with the first, but just say if you would rather make it public and I can add a to_sym instead.

@kbrock kbrock added the bug label Jul 8, 2024
@kbrock kbrock requested a review from flavorjones July 11, 2024 19:19
flavorjones
flavorjones approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@flavorjones flavorjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we should make this private, people should be using the field(default:) option.

@kbrock
Copy link
Collaborator Author

kbrock commented Jul 14, 2024

update:

  • sorry. removed first commit which was unrelated

This is now just converting a private field

@flavorjones
Copy link
Collaborator

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavorjones flavorjones flavorjones approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbrock @flavorjones