From 9e2fc62b37e5f108ed06ba2e7cd25fed40df7fb5 Mon Sep 17 00:00:00 2001 From: hatsu38 Date: Wed, 28 Aug 2024 10:08:25 +0900 Subject: [PATCH] refactor: fix typo & use private :symbol --- lib/enum/enum.rb | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/enum/enum.rb b/lib/enum/enum.rb index a93ef4f..3d55e29 100644 --- a/lib/enum/enum.rb +++ b/lib/enum/enum.rb @@ -28,20 +28,20 @@ def delete_all super end - private - def define_enum_methods return if @enum_accessors.blank? @records&.each do |record| - enum_vallue = @enum_accessors.map { |name| record.attributes[name] }.join("_").downcase.gsub(/\W+/, '_').gsub(/^_|_$/, '') - method_name = "#{enum_vallue}?" + enum_value = @enum_accessors.map { |name| record.attributes[name] }.join("_").downcase.gsub(/\W+/, '_').gsub(/^_|_$/, '') + method_name = "#{enum_value}?" define_method(method_name) do self.id == record.id end end end + private :define_enum_methods + def set_constant(record) constant = constant_for(record, @enum_accessors) return nil if constant.blank? @@ -53,6 +53,8 @@ def set_constant(record) end end + private :set_constant + def constant_for(record, field_names) field_value = field_names.map { |name| record.attributes[name] }.join("_") if constant = !field_value.nil? && field_value.dup @@ -62,6 +64,8 @@ def constant_for(record, field_names) constant end end + + private :constant_for end end end