Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very slow when many files match filter #798

Open
2 of 5 tasks
jnicoulaud-ledger opened this issue Jul 4, 2024 · 1 comment
Open
2 of 5 tasks

Very slow when many files match filter #798

jnicoulaud-ledger opened this issue Jul 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jnicoulaud-ledger
Copy link

Description:
We use the action on a repository that contains 10K+ files, with filters:

assets:
  - changed-files:
      - any-glob-to-any-file: ['inputs/**', 'outputs/**']

When many files changes, the action runs very slow (up to 30 minutes for 10K+ files). It looks like the implementation goes over all files instead of stopping as soon as one is matched.

Action version:
v5.0.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:

  • Create a repo with 100K files
  • Configure labeler with a glob pattern to match those files
  • Create a commit that modifies all files

Expected behavior:
Action runs in a few seconds

Actual behavior:
Action runs very slow

@jnicoulaud-ledger jnicoulaud-ledger added bug Something isn't working needs triage labels Jul 4, 2024
@jnicoulaud-ledger jnicoulaud-ledger changed the title Very slow when many files match Very slow when many files match filter Jul 4, 2024
@priyagupta108
Copy link

Hello @jnicoulaud-ledger👋,
Thank you for reporting this. We will investigate it and get back to you as soon as we have some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants