Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not possible to deploy gha-runner-scale-set-controller helm chart via Fluxcd #3728

Open
4 tasks done
Mikey032 opened this issue Sep 4, 2024 · 5 comments
Open
4 tasks done
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers

Comments

@Mikey032
Copy link

Mikey032 commented Sep 4, 2024

Checks

Controller Version

0.9.3

Deployment Method

Helm

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions).
  • I've read the Changelog before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes

To Reproduce

1. Deploy the gha-runner-scale-set-controller helm chart via Fluxcd. Flux yaml files are added in additional context.
2. Deployment fails with error:

NAME	REVISION          	SUSPENDED	READY	MESSAGE                                                                                                                                                                           
arc 	0.9.3+4fda46fd8c4e	False    	False	Helm install failed for release arc systems/arc with chart [email protected]+4fda46fd8c4e: 1 error occurred:                                                                                                                                                                                                                                                              * Deployment.apps "arc-gha-rs-controller" is invalid: spec.template.labels: Invalid value: "0.9.3+4fda46fd8c4e": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

Describe the bug

The chart revision is used in the arc-gha-rs-controller Deployment which contains a + sign which is not allowed.

Describe the expected behavior

Succesfull deployment of arc-gha-rs-controller

Additional Context

apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: OCIRepository
metadata:
  name: arc
  namespace: arc-systems
spec:
  interval: 10m
  url: oci://ghcr.io/actions/actions-runner-controller-charts/gha-runner-scale-set-controller
  ref:
    tag: 0.9.3
---
apiVersion: helm.toolkit.fluxcd.io/v2
kind: HelmRelease
metadata:
  name: arc
  namespace: arc-systems
spec:
  interval: 5m
  install:
    remediation:
      retries: 10
  releaseName: arc
  targetNamespace: arc-systems
  chartRef:
    kind: OCIRepository
    name: arc

Controller Logs

None, not yet running

Runner Pod Logs

None, not yet running
@Mikey032 Mikey032 added bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers labels Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@Mikey032 Mikey032 changed the title <Please write what didn't work for you here> Not possible to deploy gha-runner-scale-set-controller helm chart via Fluxcd Sep 4, 2024
@t4eman
Copy link

t4eman commented Sep 9, 2024

I had a similar issue. I would suggest pulling from GitHub directly.

apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: GitRepository
metadata:
  name: arc
  namespace: arc-systems
spec:
  interval: 10m
  url: https://github.com/actions/actions-runner-controller
  ref:
    tag: gha-runner-scale-set-0.9.3

@Fareroo7
Copy link

Fareroo7 commented Sep 9, 2024

@mumoshu @rentziass same issue here...
Would love to see this PR merged soon!

@arnauvp-factorial
Copy link

Hi! we use flux to deploy ARC to our CI clusters.

This is the yaml for the repository:

apiVersion: source.toolkit.fluxcd.io/v1beta2
kind: HelmRepository
metadata:
  name: gha-runner-scale-set
  namespace: flux-system
spec:
  interval: 30m
  type: oci
  url: oci://ghcr.io/actions/actions-runner-controller-charts

@jhaumont
Copy link

jhaumont commented Oct 10, 2024

Hello @arnauvp-factorial

EDIT: I finally have a working solution (issue with egress filtering on the cluster...)

Can you share your helmRelease manifest ? 🙏
I currently try to setup it. I have the same HelmRepository but I have the following error:

source-controller chart pull error: failed to download chart for remote reference: failed to get 'oci://ghcr.io/actions/actions-runner-controller-charts/gha-runner-scale-set-controller:0.9.3': failed to do request: Head "https://ghcr.io/v2/actions/actions-runner-controller-charts/gha-runner-scale-set-controller/manifests/0.9.3": read tcp 10.64.9.170:48980->140.82.121.33:443: read: connection reset by peer

And the chart declaration in the HR:

chart:
    spec:
      chart: gha-runner-scale-set-controller
      version: 0.9.3
      sourceRef:
        kind: HelmRepository
        name: actions-runner-controller-charts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gha-runner-scale-set Related to the gha-runner-scale-set mode needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

5 participants