Why does the controller need to create a github client at the start?

[bm1216]

Why does the actions-runner-controller need a secret/client at the beginning of its lifecycle? In multi-tenancy mode, it can just create clients per RunnerDeployment/HRA so I am not sure why it would need the original one.

[bm1216]

I'm thinking it's because there's no flag for the controller to enable multi-tenancy mode. It's just always there and works by picking up secrets from the CustomResource. So, the original GitHub client is "always" created.

Maybe its worth modifying the controller to enable/disable multi-tenancy via flags? Error out when RunnerDeployments are created without the githubApiCredentialsFrom field. That would make more sense. Seems like a chunk of work though.

@mumoshu

[bm1216]

Just saw this - #1832 (comment)